Skip to content

python2 minor fix #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 19, 2023
Merged

python2 minor fix #518

merged 4 commits into from
Oct 19, 2023

Conversation

mirageoasis
Copy link
Contributor

@mirageoasis mirageoasis commented Oct 13, 2023 •
edited
Loading

In this pr I think change was too radical
link

so I only remove python2 compatibliity and did some minor fixes

sean-k1
sean-k1 reviewed Oct 15, 2023
View reviewed changes
Copy link
Collaborator

@sean-k1 sean-k1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good except for this
Can you check?

@dongwook-chan dongwook-chan merged commit d180d65 into julien-duponchelle:main Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sean-k1 sean-k1 sean-k1 left review comments

@dongwook-chan dongwook-chan dongwook-chan left review comments

Assignees
No one assigned
Labels
hacktoberfest-accepted release-1.0.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mirageoasis @sean-k1 @dongwook-chan